Skip to content

Verify and document stack buffer escape analysis in batch operations #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Verify and document stack buffer escape analysis in batch operations #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
003e608
Initial plan
Copilot Nov 2, 2025
c5eeb23
docs: verify and document stack buffer escape analysis
Copilot Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions bloomfilter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ func (bf *CacheOptimizedBloomFilter) AddBatch(items [][]byte) {
}

// Stack-allocate positions buffer for typical filters (hashCount ≤ 8)
// Escape analysis confirms: positions does not escape when used locally
// Verified with go build -gcflags='-m': stackBuf and positions do not escape
// - positions slice is only read in loop, never stored or passed to goroutines
// - setBitCacheOptimizedWithOps reads positions without capturing it
// Covers ~90% of use cases (FPR >= 0.01, where hashCount ≈ 7)
var positions []uint64
if bf.hashCount <= 8 {
Expand Down Expand Up @@ -191,7 +193,9 @@ func (bf *CacheOptimizedBloomFilter) AddBatchString(items []string) {
}

// Stack-allocate positions buffer for typical filters (hashCount ≤ 8)
// Escape analysis confirms: positions does not escape when used locally
// Verified with go build -gcflags='-m': stackBuf and positions do not escape
// - positions slice is only read in loop, never stored or passed to goroutines
// - setBitCacheOptimizedWithOps reads positions without capturing it
// Covers ~90% of use cases (FPR >= 0.01, where hashCount ≈ 7)
var positions []uint64
if bf.hashCount <= 8 {
Expand Down Expand Up @@ -243,7 +247,9 @@ func (bf *CacheOptimizedBloomFilter) AddBatchUint64(items []uint64) {
}

// Stack-allocate positions buffer for typical filters (hashCount ≤ 8)
// Escape analysis confirms: positions does not escape when used locally
// Verified with go build -gcflags='-m': stackBuf and positions do not escape
// - positions slice is only read in loop, never stored or passed to goroutines
// - setBitCacheOptimizedWithOps reads positions without capturing it
// Covers ~90% of use cases (FPR >= 0.01, where hashCount ≈ 7)
var positions []uint64
if bf.hashCount <= 8 {
Expand Down