Skip to content

feat: Add 3D Poiseuille flow validation test and complete v0.2.0 mile… #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaia merged 3 commits into from
Mar 7, 2026
Merged

feat: Add 3D Poiseuille flow validation test and complete v0.2.0 mile… #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18edd64
feat: Add 3D Poiseuille flow validation test and complete v0.2.0 mile…
shaia Mar 7, 2026
cdc1ac6
fix: Enforce w boundary conditions on x-inlet/x-outlet faces in 3D Po…
shaia Mar 7, 2026
9e13270
fix: Use stride_z for periodic BC plane_bytes instead of duplicating …
shaia Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ if(BUILD_TESTS)

# Poiseuille flow validation test
add_executable(test_poiseuille_flow tests/validation/test_poiseuille_flow.c)
add_executable(test_poiseuille_3d tests/validation/test_poiseuille_3d.c)

# 3D validation tests
add_executable(test_taylor_green_3d tests/validation/test_taylor_green_3d.c)
Expand Down Expand Up @@ -396,6 +397,7 @@ if(BUILD_TESTS)
target_link_libraries(test_taylor_green_3d PRIVATE CFD::Library unity)
target_link_libraries(test_quiescent_3d PRIVATE CFD::Library unity)
target_link_libraries(test_poiseuille_flow PRIVATE CFD::Library unity)
target_link_libraries(test_poiseuille_3d PRIVATE CFD::Library unity)
target_link_libraries(test_finite_differences PRIVATE unity $<$<NOT:$<PLATFORM_ID:Windows>>:m>)
target_include_directories(test_finite_differences PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/lib/include)
target_link_libraries(test_finite_differences_3d PRIVATE unity $<$<NOT:$<PLATFORM_ID:Windows>>:m>)
Expand Down Expand Up @@ -513,8 +515,9 @@ if(BUILD_TESTS)
add_test(NAME TaylorGreen3DTest COMMAND test_taylor_green_3d)
add_test(NAME Quiescent3DTest COMMAND test_quiescent_3d)

# Poiseuille flow validation test
# Poiseuille flow validation tests
add_test(NAME PoiseuilleFlowTest COMMAND test_poiseuille_flow)
add_test(NAME Poiseuille3DTest COMMAND test_poiseuille_3d)

# Mathematical accuracy tests
add_test(NAME FiniteDifferencesTest COMMAND test_finite_differences)
Expand Down Expand Up @@ -552,7 +555,10 @@ if(BUILD_TESTS)
GhiaProjectionOmpTest
GhiaProjectionGpuTest
TaylorGreenVortexTest
TaylorGreen3DTest
Quiescent3DTest
PoiseuilleFlowTest
Poiseuille3DTest
ConvergenceOrderTest
PROPERTIES LABELS "validation"
)
Expand Down
4 changes: 2 additions & 2 deletions ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,8 @@ Alternative to full C inference (Phase 7). Python handles training/orchestration
### v0.2.0 - 3D Support

- [x] Phases 0–4: Indexing macros, core data structures, 3D stencils, NS solvers, BCs
- [ ] Phase 5-7: SIMD, OMP, CUDA backends for 3D
- [ ] Phase 8: 3D VTK output, examples, validation (Taylor-Green 3D, Poiseuille 3D)
- [x] Phase 5-7: SIMD, OMP, CUDA backends for 3D
- [x] Phase 8: 3D VTK output, examples, validation (Taylor-Green 3D, Poiseuille 3D)

### v0.3.0 - Heat Transfer

Expand Down
Loading
Loading