Repository navigation
Fix GitHub login redirect_uri after the custom domain - #76
Closed
shangeethsivan wants to merge 1 commit into
Closed
shangeethsivan wants to merge 1 commit into
shangeethsivan wants to merge 1 commit into
Conversation
Sign-in was using the incoming hostname as redirect_uri. After the custom domain, that no longer matches the GitHub App. Always use SYNCIDIAN_PUBLIC_URL and show the exact Callback URL on the operator page. Co-authored-by: shangeeth95 <shangeeth95@gmail.com>
shangeethsivan
marked this pull request as ready for review
September 3, 2026 19:05
Owner
Author
|
Closing as it works now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub shows Be careful! The
redirect_uriis not associated with this application because Syncidian sendshttps://syncidian.com/api/v1/auth/github/callback, and the GitHub App still has the old Railway callback (or is missing this URL).This PR
SYNCIDIAN_PUBLIC_URL(githubBase), so a Railway or Tailscale host cannot send a differentredirect_uri.You still have to update the GitHub App (cannot be done from the API)
https://syncidian.com/...URLs from/adminif they still point at*.up.railway.app.Do not create a new GitHub App. Keep the existing App ID, Client ID, secret, and private key.