Add CodeQL analysis workflow configuration - #1
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
shanujans
added a commit
that referenced
this pull request
Jul 17, 2026
Three paths could return a USD price instead of LKR: 1. normalizeJsonProduct (primary MCP path): price object's currency field was ignored — now only accepts LKR/Rs prices, sets price=0 otherwise so the UI merges the search-result LKR price. 2. fetchKaprukaPage meta-tag fallback: product:price:amount was read without checking product:price:currency — on Vercel (US IPs) Kapruka serves international pages with USD meta prices. Now only accepts the meta price when currency is explicitly LKR. 3. ProductModal merge: isGarbage required ALL fields to be bad, so a product with good images/description but price=0 (from fix #1) would still show price=0. Now patches in the fallback search LKR price when API price is 0, keeping all rich API data.
shanujans
added a commit
that referenced
this pull request
Jul 25, 2026
Three paths could return a USD price instead of LKR: 1. normalizeJsonProduct (primary MCP path): price object's currency field was ignored — now only accepts LKR/Rs prices, sets price=0 otherwise so the UI merges the search-result LKR price. 2. fetchKaprukaPage meta-tag fallback: product:price:amount was read without checking product:price:currency — on Vercel (US IPs) Kapruka serves international pages with USD meta prices. Now only accepts the meta price when currency is explicitly LKR. 3. ProductModal merge: isGarbage required ALL fields to be bad, so a product with good images/description but price=0 (from fix #1) would still show price=0. Now patches in the fallback search LKR price when API price is 0, keeping all rich API data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.