Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling an HTTP request before the upstream server sends response headers now closes the upstream request. Previously, navigating away from an expensive history search could leave that search running and delay subsequent requests. Disconnects also stop buffered HTML and error responses; finishing an upload normally still leaves its response pending.
The proxy registers disconnect cleanup when it creates the upstream request and avoids writing errors to a response that has already closed.
Validation:
npm test(178 passed); seven HTTP cancellation regressions also passed on Windows Node 24.20.0. GET, POST, and partial-upload cancellation tests fail on v2.10.6 before this fix. Two independent runs of the new test file passed concurrently.