Fix truncated-horizon evaluation masks - #3
Draft
Arison591 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action_is_padto the requestedaction_horizonalongside the ground-truth action chunk.Root cause and impact
evaluate_batch()supports evaluating fewer action steps than are stored in the batch. It already slicedaction_gtto that horizon, but passed the full-length padding mask toaction_mse(). For example, evaluating a 2-step horizon from a 4-step chunk failed while expanding a[B, 4]mask over a[B, 2, D]tensor:The mask now follows the same horizon as the target, so truncated-horizon metrics both run and continue to exclude padded steps.
Validation
python -m pytest -q tests/test_metrics.py— 1 passedpython -m ruff check starwam/training/metrics.py tests/test_metrics.py— passedpython -m compileall -q starwam tests— passed{"action_mse": 1.0}No model weights, dataset, or external service are required for the regression test.