feat: community invites#421
Draft
Droid00000 wants to merge 4 commits into
Draft
Conversation
Droid00000
force-pushed
the
feat/community-invites
branch
from
37b0137 to
5a8e150
Compare
Droid00000
force-pushed
the
feat/community-invites
branch
3 times, most recently
from
103a8e4 to
ff1896c
Compare
Droid00000
force-pushed
the
feat/community-invites
branch
2 times, most recently
from
d1aaa65 to
a2bd8aa
Compare
Droid00000
force-pushed
the
feat/community-invites
branch
from
e87976b to
6d5f79a
Compare
Droid00000
force-pushed
the
feat/community-invites
branch
2 times, most recently
from
da41765 to
569f232
Compare
Droid00000
force-pushed
the
feat/community-invites
branch
from
baf1402 to
9f8f48c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This API uses CSV files, but despite this, the actual formatting of the CSV is not validated or sanitized at all, and when fetching the
target_users, you are returned the input file exactly as it was uploaded. Of course always requiring a file is not a good idea, which is why we can useStringIOto accept an array and then create a fake "File" to foolRestClient.Added
Invite#flagsInvite#rolesInvite#target_usersInvite#target_users=Channel#create_inviteInvite#target_users_workerInvite#expires_atInvite#stream_userInvite#embedded_applicationAPI::Channel#create_invite!API::Invite#get_target_usersAPI::Invite#update_target_usersAPI::Invite#get_target_users_job_statusDeprecated
Channel#make_inviteRemoved
Bot#accept_inviteAPI::Invite#accept