feat: comparison operators for roles#422
Open
Droid00000 wants to merge 1 commit into
Open
Conversation
Droid00000
force-pushed
the
feat/comparable-roles
branch
from
662660b to
13b4bad
Compare
Droid00000
force-pushed
the
feat/comparable-roles
branch
5 times, most recently
from
d037d17 to
52aaa13
Compare
Member
|
This one is a little fancy, let me stew on it a bit longer |
Droid00000
force-pushed
the
feat/comparable-roles
branch
from
74bfbb9 to
9c0859b
Compare
Droid00000
force-pushed
the
feat/comparable-roles
branch
from
9d2a1e5 to
aeba3ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
>,<,<=,>=, and<=>operators for comparing roles via their position in the hierarchy. I understand this may be an unwanted change, but it makes comparing roles by their position a lot easier. Other libraries implement similar interfaces too. Additionally, by implementing the Darth Vader ship operator<=>, calling#sorton anArray<Role>now behaves correctly.Added
Role#>Role#<Role#<=Role#>=Role#between?