fix: voice UDP causes main gateway to stop acking heartbeats#439
Open
Droid00000 wants to merge 1 commit into
Open
fix: voice UDP causes main gateway to stop acking heartbeats#439Droid00000 wants to merge 1 commit into
Droid00000 wants to merge 1 commit into
Conversation
Droid00000
changed the title
Droid00000
force-pushed
the
fix/properly-disconnect-voice-gateway
branch
from
5321855 to
f22fa4e
Compare
Droid00000
force-pushed
the
fix/properly-disconnect-voice-gateway
branch
from
4cf75cd to
a16ea22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A while ago, I got an issue where after connecting to the VWS failed, the the VWS would not properly close and still attempted to send heartbeats. Additionally, because
@socket.recv(74)reads from a socket and blocks, and we have other threads, this would cause the main Gateway thread to somehow stop receiving data too, because after the failed voice connection attempt, my bot wouldn't respond to any slash commands, and eventually I'd see a debug message stating that the last heartbeat was not acked, and then the code would just indefinitely hang. After much fucking around, adding a timeout to the#receive_discovery_replyseems to fix this, and none of the problems above seem to be an issue.