Add support for vertical,horizontal grid layout.#44
Open
xsahil03x wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance the functionality of the
ShimmerRecyclerViewby adding support for both vertical and horizontal grid layouts. The most important changes include updating the layout XML files, modifying theShimmerRecyclerViewclass to handle new layout manager types, and updating the attributes XML file.Enhancements to
ShimmerRecyclerView:shimmer/src/main/java/com/cooltechworks/views/shimmer/ShimmerRecyclerView.java: Added support forGRID_VERTICALandGRID_HORIZONTALlayout manager types and updated theinitmethod to handle these new types. [1] [2] [3]Updates to layout XML files:
app/src/main/res/layout/activity_grid.xml: Changedshimmer_demo_layout_manager_typefromgridtogrid_vertical.app/src/main/res/layout/activity_second_grid.xml: Changedshimmer_demo_layout_manager_typefromgridtogrid_vertical.Updates to attributes XML file:
shimmer/src/main/res/values/attrs.xml: Updatedshimmer_demo_layout_manager_typeto includegrid_verticalandgrid_horizontalenums.