Skip to content

encode-timestamp handles DST #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuel-jimenez wants to merge 3 commits into
base: master
Choose a base branch
from
Open

encode-timestamp handles DST #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f66dcf
encode-timestamp handles DST
samuel-jimenez Aug 5, 2020
195daa2
Merge remote-tracking branch 'upstream/master' into encode-timestamp-…
samuel-jimenez Nov 23, 2020
413919d
Update local-time.lisp
samuel-jimenez Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/local-time.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@
(values (elt (timezone-subzones timezone) subzone-idx)
transition-idx)))

(defun %guess-offset (seconds days &optional timezone)
(defun %guess-unix-offset (unix-time &optional timezone)
;; try converting the local time to a timestamp using each available
;; subtimezone, until we find one where the offset matches the offset that
;; applies at that time (according to the transition table).
Expand All @@ -213,10 +213,20 @@
;; Whichever subtimezone is listed first in the tzinfo database will be
;; the one that we pick to resolve ambiguous local time representations.
(let* ((zone (%realize-timezone (or timezone *default-timezone*)))
(unix-time (timestamp-values-to-unix seconds days))
(subzone (%subzone-as-of zone unix-time)))
(subzone-idx (if (zerop (length (timezone-indexes zone)))
0
(elt (timezone-indexes zone)
(transition-position unix-time
(timezone-transitions zone)))))
(subzone (elt (timezone-subzones zone) subzone-idx)))
(subzone-offset subzone)))

(defun %guess-offset (seconds days &optional timezone)
;; check that guessed offset still applies
(let* ((unix-time (timestamp-values-to-unix seconds days))
(offset (%guess-unix-offset unix-time timezone)))
(%guess-unix-offset (- unix-time offset) timezone)))

(defun %read-binary-integer (stream byte-count &optional (signed nil))
"Read BYTE-COUNT bytes from the binary stream STREAM, and return an integer which is its representation in network byte order (MSB). If SIGNED is true, interprets the most significant bit as a sign indicator."
(loop
Expand Down