-
Notifications
You must be signed in to change notification settings - Fork 0
Add executable BitNet paper audit and surface it in benchmark reports #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
02b4b95
Initial plan
Copilot 657571b
feat: add datagen jsonl generator command
Copilot f3414d9
fix: polish datagen docs and validation loop
Copilot 3cf371a
merge: integrate pr16 datagen prompt flow
Copilot 8f68ceb
fix: reject low-quality datagen candidates
Copilot 3681663
fix: polish merged datagen quality heuristics
Copilot d1ce4dd
Merge branch 'main' into copilot/add-datagene-slm-generator
sharpninja 308e863
fix: remove duplicate datagen seeds variable
Copilot bc65ebf
fix: clarify datagen fallback acceptance error
Copilot 19f0e29
test: cover paper topology specflow and benchmark execution
Copilot 6675f23
feat: add executable paper audit and benchmark report integration
Copilot 1c812f3
fix: finalize benchmark report artifact copy order
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| using System.Text; | ||
| using BitNetSharp.Core; | ||
|
|
||
| namespace BitNetSharp.App; | ||
|
|
||
| public static class BitNetPaperAuditCommand | ||
| { | ||
| public static string FormatReport(BitNetPaperAuditReport report) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(report); | ||
|
|
||
| var builder = new StringBuilder(); | ||
| builder.AppendLine($"Paper-alignment audit: {report.ModelId}"); | ||
| builder.AppendLine(report.DisplayName); | ||
| builder.AppendLine($"Passed: {report.PassedCount}"); | ||
| builder.AppendLine($"Pending: {report.PendingCount}"); | ||
| builder.AppendLine($"Failed: {report.FailedCount}"); | ||
| builder.AppendLine(); | ||
|
|
||
| foreach (var check in report.Checks) | ||
| { | ||
| builder.AppendLine($"[{FormatStatus(check.Status)}] {check.Area} - {check.Requirement}"); | ||
| builder.AppendLine($" {check.Details}"); | ||
| } | ||
|
|
||
| return builder.ToString().TrimEnd(); | ||
| } | ||
|
|
||
| private static string FormatStatus(BitNetPaperAuditStatus status) => status switch | ||
| { | ||
| BitNetPaperAuditStatus.Passed => "PASS", | ||
| BitNetPaperAuditStatus.Pending => "PENDING", | ||
| BitNetPaperAuditStatus.Failed => "FAIL", | ||
| _ => status.ToString().ToUpperInvariant() | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section claims the implementation performs “prompt/response schema validation,” but the current
ComputeQualityScorelogic only checks for non-empty prompt/response and doesn’t validate against--output-schema(or any structured schema) before accepting. Either implement schema/format validation or adjust this doc wording to match the current behavior.