Skip to content

Improve public recall eval case quality #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheawinkler merged 1 commit into from
May 30, 2026
Merged

Improve public recall eval case quality #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion services/gateway-go/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,12 +1270,15 @@ func TestRecallEvalCasesRefreshUsesLiveFileBackedMemory(t *testing.T) {
if strings.HasPrefix(anyToString(item["id"]), "health-") {
t.Fatalf("refresh should not fall back to default cases, got %#v", cases)
}
if len(anyToStringSlice(item["expected_files"])) == 0 {
if len(anyToStringSlice(item["expected_files"])) != 1 {
t.Fatalf("expected file-backed recall case, got %#v", item)
}
if !strings.Contains(anyToString(item["query"]), "recall") {
t.Fatalf("expected topic-derived recall query, got %#v", item)
}
if anyToString(item["project"]) != "contextlattice" {
t.Fatalf("expected case to stay project-scoped, got %#v", item)
}
}
}

Expand Down
163 changes: 108 additions & 55 deletions services/gateway-go/memory_misc_routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"net/http"
"os"
"path/filepath"
"sort"
"strconv"
"strings"
"time"
Expand Down Expand Up @@ -539,74 +540,49 @@ func (s *server) buildRefreshedRecallEvalCaseSet(maxCases int, minHits int, proj
topicPrefix = recallEvalNormalizeTopicPath(topicPrefix)
cases := make([]map[string]any, 0, maxCases)
if s.memoryStore != nil && s.memoryStore.policy.enabled {
rollups := s.memoryStore.topicRollupsWithContext(context.Background(), project, minHits, maxCases*6, 0)
if rowsAny, ok := rollups["topics"].([]any); ok {
for _, item := range rowsAny {
row := anyMap(item)
topic := recallEvalNormalizeTopicPath(anyToString(row["topic_path"]))
if topic == "" {
topic = recallEvalNormalizeTopicPath(anyToString(row["path"]))
}
if topicPrefix != "" && !strings.HasPrefix(topic, topicPrefix) {
continue
}
hits := anyToInt(row["event_count"], anyToInt(row["eventCount"], 0))
if hits < minHits {
continue
}
query := strings.TrimSpace(strings.ReplaceAll(topic, "/", " "))
summarySnippets := recallEvalSummarySnippets(row)
if query == "" && len(summarySnippets) > 0 {
query = strings.TrimSpace(summarySnippets[0])
}
if query == "" {
continue
}
expectedFiles := recallEvalExpectedFilesFromTopic(row)
expectedTerms := []string{}
for _, summary := range summarySnippets {
expectedTerms = append(expectedTerms, clipText(strings.ToLower(summary), 64))
if len(expectedTerms) >= 2 {
break
}
}
cases = append(cases, map[string]any{
"id": recallEvalCaseID(topic, len(cases)),
"query": query,
"project": project,
"topic_path": topic,
"limit": 10,
"expected_files": expectedFiles,
"expected_substrings": expectedTerms,
})
if len(cases) >= maxCases {
break
}
}
docs, err := s.memoryStore.collectDocs(context.Background(), project)
if err == nil {
cases = recallEvalCasesFromDocs(docs, maxCases, minHits, project, topicPrefix)
}
if len(cases) == 0 {
docs, err := s.memoryStore.collectDocs(context.Background(), project)
if err == nil {
for _, doc := range docs {
topic := recallEvalNormalizeTopicPath(doc.TopicPath)
rollups := s.memoryStore.topicRollupsWithContext(context.Background(), project, minHits, maxCases*6, 0)
if rowsAny, ok := rollups["topics"].([]any); ok {
for _, item := range rowsAny {
row := anyMap(item)
topic := recallEvalNormalizeTopicPath(anyToString(row["topic_path"]))
if topic == "" {
topic = recallEvalNormalizeTopicPath(anyToString(row["path"]))
}
if topicPrefix != "" && !strings.HasPrefix(topic, topicPrefix) {
continue
}
query := recallEvalQueryFromDoc(doc)
if query == "" || strings.TrimSpace(doc.FileName) == "" {
hits := anyToInt(row["event_count"], anyToInt(row["eventCount"], 0))
if hits < minHits {
continue
}
query := strings.TrimSpace(strings.ReplaceAll(topic, "/", " "))
summarySnippets := recallEvalSummarySnippets(row)
if query == "" && len(summarySnippets) > 0 {
query = strings.TrimSpace(summarySnippets[0])
}
if query == "" {
continue
}
expectedFiles := recallEvalExpectedFilesFromTopic(row)
expectedTerms := []string{}
if summary := strings.TrimSpace(doc.Summary); summary != "" {
for _, summary := range summarySnippets {
expectedTerms = append(expectedTerms, clipText(strings.ToLower(summary), 64))
if len(expectedTerms) >= 2 {
break
}
}
cases = append(cases, map[string]any{
"id": recallEvalCaseID(doc.Project+"::"+doc.FileName, len(cases)),
"id": recallEvalCaseID(topic, len(cases)),
"query": query,
"project": doc.Project,
"project": project,
"topic_path": topic,
"limit": 10,
"expected_files": []string{doc.FileName},
"expected_files": expectedFiles,
"expected_substrings": expectedTerms,
})
if len(cases) >= maxCases {
Expand Down Expand Up @@ -635,6 +611,82 @@ func (s *server) buildRefreshedRecallEvalCaseSet(maxCases int, minHits int, proj
}
}

func recallEvalCasesFromDocs(docs []memoryStoreDoc, maxCases int, minHits int, project string, topicPrefix string) []map[string]any {
topicCounts := map[string]int{}
for _, doc := range docs {
topic := recallEvalNormalizeTopicPath(doc.TopicPath)
if topic == "" {
continue
}
topicCounts[topic] += 1
}
filtered := make([]memoryStoreDoc, 0, len(docs))
for _, doc := range docs {
if strings.TrimSpace(doc.FileName) == "" {
continue
}
topic := recallEvalNormalizeTopicPath(doc.TopicPath)
if topicPrefix != "" && !strings.HasPrefix(topic, topicPrefix) {
continue
}
if minHits > 1 && topicCounts[topic] < minHits {
continue
}
if recallEvalQueryFromDoc(doc) == "" {
continue
}
filtered = append(filtered, doc)
}
sort.SliceStable(filtered, func(i, j int) bool {
leftTopic := recallEvalNormalizeTopicPath(filtered[i].TopicPath)
rightTopic := recallEvalNormalizeTopicPath(filtered[j].TopicPath)
leftDepth := topicDepth(leftTopic)
rightDepth := topicDepth(rightTopic)
if leftDepth != rightDepth {
return leftDepth > rightDepth
}
if !filtered[i].UpdatedAt.Equal(filtered[j].UpdatedAt) {
return filtered[i].UpdatedAt.After(filtered[j].UpdatedAt)
}
return strings.TrimSpace(filtered[i].FileName) < strings.TrimSpace(filtered[j].FileName)
})
seen := map[string]struct{}{}
cases := make([]map[string]any, 0, maxCases)
for _, doc := range filtered {
fileName := strings.Trim(strings.TrimSpace(doc.FileName), "/")
if fileName == "" {
continue
}
dedupeKey := strings.ToLower(strings.TrimSpace(doc.Project + "::" + fileName))
if _, ok := seen[dedupeKey]; ok {
continue
}
seen[dedupeKey] = struct{}{}
topic := recallEvalNormalizeTopicPath(doc.TopicPath)
expectedTerms := []string{}
if summary := strings.TrimSpace(doc.Summary); summary != "" {
expectedTerms = append(expectedTerms, clipText(strings.ToLower(summary), 96))
}
caseProject := strings.TrimSpace(doc.Project)
if caseProject == "" {
caseProject = project
}
cases = append(cases, map[string]any{
"id": recallEvalCaseID(caseProject+"::"+fileName, len(cases)),
"query": recallEvalQueryFromDoc(doc),
"project": caseProject,
"topic_path": topic,
"limit": 10,
"expected_files": []string{fileName},
"expected_substrings": expectedTerms,
})
if len(cases) >= maxCases {
break
}
}
return cases
}

func recallEvalSummarySnippets(row map[string]any) []string {
snippets := make([]string, 0, 3)
for _, item := range anyToStringSlice(row["summarySnippets"]) {
Expand Down Expand Up @@ -683,7 +735,8 @@ func recallEvalQueryFromDoc(doc memoryStoreDoc) string {
fileName := strings.TrimSpace(doc.FileName)
fileStem := strings.TrimSuffix(fileName, filepath.Ext(fileName))
fileStem = strings.ReplaceAll(fileStem, "/", " ")
query := strings.TrimSpace(topic + " " + fileStem)
summary := clipText(doc.Summary, 120)
query := strings.TrimSpace(strings.Join([]string{topic, fileStem, summary}, " "))
if query != "" {
return query
}
Expand Down
Loading