Repository navigation
Fix credential exposure, configuration recovery and monitoring bottlenecks - #151
Conversation
Redact service credentials, preserve current secrets during concurrent edits, retain Nginx batch backups, persist maintenance activation retries, refill monitor workers, refresh Analytics mappings and stabilize editing dialogs. Harden native maintenance and gate latest image publication on native smokes. Add regression coverage and update the internal wiki.
Use the repository's pinned Biome formatter, update agent context, and remove the temporary read-only formatter bootstrap after successful validation.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1a4598b50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| ); | ||
| const _saved_row = utils.omitRow(omissions())(new_saved_row); | ||
| await notifyProxyHostDomainsChanged(); |
There was a problem hiding this comment.
Wire the new domain-change notification into the Tor integration as well. syncProxyHost() inserts an onion domain at backend/internal/tor.js:208, and Tor reassignment deletes/inserts domains at lines 314–322, but neither path calls this notifier. After creating or moving an onion service, requests for the affected .onion hostname are therefore attributed to host 0 or the previous host until the ten-minute fallback refresh, producing inaccurate analytics despite the new immediate-refresh mechanism.
Useful? React with 👍 / 👎.
Read-only Cloudflare, DDNS and Access List responses exposed service credentials, and configuration failures could leave missing Nginx listeners or permanently unactivated maintenance changes. This change removes those exposures and makes failed activation recoverable while addressing all 13 findings from the October 13 review.
Validation on d1a4598:
The migration adds a private maintenance_pending field. Public service APIs expose configured indicators instead of secret values. Native rollback covers application files before migration startup; system packages, rootfs, binaries and database changes retain their documented recovery limits. The manual latest publishing workflow has not been dispatched.