Repository navigation
Fix dependency update compatibility and strengthen test gates - #152
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fadf8ab6c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "refractor": "5.0.0", | ||
| "rehype-prism-plus": "2.0.2", |
There was a problem hiding this comment.
Updating these direct dependencies without regenerating THIRD-PARTY-NOTICES.md leaves the repository’s generated license inventory inaccurate: it still lists refractor@4.9.0 and rehype-prism-plus@2.0.0, while the manifest and lockfile now install 5.0.0 and 2.0.2. The temporary workflow only uploads its regenerated file as an artifact, so it does not correct the notice consumed from the checkout; run scripts/generate-notices.js with the committed dependency set and include the resulting notice.
Useful? React with 👍 / 👎.
Dependency-update run #38463175903 failed because the code editor imported removed Refractor paths. The editor now uses Refractor 5 public exports with the compatible rehype-prism-plus 2.0.2 adapter; selected grammars, rendering and type compatibility are preserved.
The test review replaces copied backend logic with actual service/middleware checks, restores global/mock state, verifies rejected ChatOps access and startup/shutdown ordering, and removes clock-based flakes. Frontend tests clean QueryClients and stale mutation implementations; browser smokes fail on uncaught errors. Dockerlint now fails tool/process errors and keeps complete diagnostics across every Dockerfile.
Dependency updates run backend types, both complete suites, locales, the production build and bundle budget through an executable fail-fast gate. Manifests, lockfiles and update reports survive failures as artifacts. Superseded PR image checks are cancelled automatically; publishing runs and the release job remain serialized. Application version remains 4.4.1; updated highlighting lockfiles and third-party notices were generated from installed packages. Internal test/build documentation is updated.
Validation: both locked and latest dependency jobs passed on the corrected source (compatibility run #38466520461): 2,161 backend tests with 4 intentional skips; 931 frontend tests; 7 Chromium smokes; backend/frontend types, locales, build and bundle budget; 73 scanner integration tests and a clean scanner run; 164 infrastructure tests with 2 CI skips (21 local environment skips). The temporary read-only validation workflow has been removed. On final commit 7ea0da3, all eight PR workflows and the push quality workflow passed. Native Docker validation passed on x86_64 and aarch64: GeoIP bootstrap across two boots, runtime smokes as UID 0 and UID 1000, firewall/gRPC/stream/access-rule checks, and native installer/LXC artifact creation. PR publishing jobs were correctly skipped.