Skip to content

[housekeeping] Automated PR to fix formatting errors#3

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
housekeeping/fix-codeformatting
Open

[housekeeping] Automated PR to fix formatting errors#3
github-actions[bot] wants to merge 1 commit into
mainfrom
housekeeping/fix-codeformatting

Conversation

@github-actions

Copy link
Copy Markdown

Automated PR to fix formatting errors

@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 4 times, most recently from bf20cf0 to 3f3a60a Compare March 4, 2025 00:17
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 4 times, most recently from fe305e2 to 31a40dc Compare March 12, 2025 00:17
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 5 times, most recently from 518e1bf to 152d762 Compare March 25, 2025 00:21
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 3 times, most recently from 8cfdabf to f79b720 Compare March 29, 2025 00:17
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 2 times, most recently from 39ae3a8 to 33add5b Compare April 11, 2025 00:19
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 5 times, most recently from c270bf8 to b2e21eb Compare April 18, 2025 00:16
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 4 times, most recently from 3504d4b to 97ac096 Compare April 29, 2025 00:21
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch from 97ac096 to 8457f71 Compare April 30, 2025 00:18
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch 3 times, most recently from 197e22f to 2dcb68c Compare May 8, 2025 00:18
@github-actions github-actions Bot force-pushed the housekeeping/fix-codeformatting branch from 2dcb68c to cd57243 Compare May 10, 2025 00:18
sheiksyedm pushed a commit that referenced this pull request Jan 14, 2026
…tnet#33071)

App crashes because of changing a shared Drawable on the fly. I found
out it is the SearchBar. It only happens on Android and in large apps
with lots of screens. Unfortunately I can't reproduce it in the
TestSuite. But by reading the docs of Android this crash is common and
caused by changing a Drawable which is still referenced. With a custom
SearchBarHandler the issues is resolved.

```Backtrace (top frames):
  #00 pc 00000000006b8694  /system/lib64/libhwui.so
      android::getRootAlpha(_JNIEnv*, _jobject*, long) +4

  #1 pc 0000000002256c90  /memfd:jit-cache (deleted)
      art_jni_trampoline +112

  #2 pc 000000000223bc4c  /memfd:jit-cache (deleted)
      android.graphics.drawable.VectorDrawable.-$$Nest$smnGetRootAlpha +108

  #3 pc 000000000223bb20  /memfd:jit-cache (deleted)
      android.graphics.drawable.VectorDrawable$VectorDrawableState.getAlpha +144

  #4 pc 00000000025c50e0  /memfd:jit-cache (deleted)
      android.graphics.drawable.VectorDrawable.getAlpha +128

  #5 pc 00000000025c4f9c  /memfd:jit-cache (deleted)
      android.graphics.drawable.VectorDrawable.getOpacity +124

  #6 pc 00000000025c1ea8  /memfd:jit-cache (deleted)
      android.widget.ImageView.isOpaque +152

  #7 pc 000000000227979c  /memfd:jit-cache (deleted)
      android.view.View.invalidateInternal +428

  #8 pc 00000000025c4790  /memfd:jit-cache (deleted)
      android.widget.ImageView.invalidateDrawable +256

  #9 pc 000000000224419c  /memfd:jit-cache (deleted)
      android.graphics.drawable.Drawable.invalidateSelf +156

  #10 pc 000000000260e710  /memfd:jit-cache (deleted)
      android.graphics.drawable.VectorDrawable.setTintList +192

  #11 pc 00000000025d0094  /memfd:jit-cache (deleted)
      **android.graphics.drawable.Drawable.setTint +148**
```

### Description of Change

- Changes tinting of Androids SearchBar to unified setTint instead of
setColorFilter
-  Mutates the drawable before setting the tint.

### Issues Fixed
Issue is fixed with a custom handler for now.

Fixes dotnet#33070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants