Create list blob example - #10
Conversation
a853684 to
043f4ff
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR creates a new example application demonstrating how to list blobs from a Shelby account using the Shelby SDK.
Key changes:
- Adds a new
list-blobexample application with TypeScript configuration and dependencies - Implements blob listing functionality that retrieves and displays blob metadata (name, size, expiration)
- Provides comprehensive documentation including setup instructions, usage examples, and troubleshooting guidance
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/list-blob/tsconfig.json | TypeScript configuration for the list-blob example app |
| apps/list-blob/src/index.ts | Main application logic for listing blobs from a Shelby account |
| apps/list-blob/package.json | Package configuration with dependencies and scripts |
| apps/list-blob/README.md | Comprehensive documentation for setup and usage |
| apps/list-blob/.env.example | Example environment variables template |
| README.md | Updated root README to include the new list-blob example |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| console.log(`Found ${blobs.length} blob(s)`); | ||
| for (const blob of blobs) { | ||
| console.log( | ||
| `· ${blob.name} — ${blob.size} bytes, expires: ${new Date(blob.expirationMicros / 1000).toISOString()}`, |
There was a problem hiding this comment.
The expiration time conversion appears incorrect. expirationMicros suggests microseconds, but dividing by 1000 converts to milliseconds. The Date constructor expects milliseconds, so this should divide by 1000000 to properly convert microseconds to milliseconds.
* add example to store ai generated images on shelby * address comments * fmt
GhostWalker562
left a comment
GhostWalker562
left a comment
There was a problem hiding this comment.
Overall it looks good, although there's a second pnpm-lock.yaml in apps/ai-image-generation, I'm assuming that should be removed first?
|
That file is rebased from @0xmaayan's PR, I will ask about it! |
No description provided.