Add cross chain accounts example - #3
Merged
Merged
Conversation
0xmaayan
force-pushed
the
cross_chain_accounts
branch
from
September 25, 2025 17:10
4f36745 to
b46f7d8
Compare
hariria
reviewed
Sep 25, 2025
hariria
left a comment
hariria
left a comment
Contributor
There was a problem hiding this comment.
CI failing, need to run pnpm update-table
0xmaayan
force-pushed
the
cross_chain_accounts
branch
from
September 25, 2025 17:28
fbdc30f to
c7e61af
Compare
hariria
reviewed
Sep 25, 2025
hariria
left a comment
hariria
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, but two things:
- Can we get a screen recording in the PR description for what it looks like?
- Should we deploy to Vercel for people to see what the demo looks like?
| @@ -0,0 +1,116 @@ | |||
| import { | |||
Contributor
There was a problem hiding this comment.
Cool. We should probably make another library / npm package for hooks like this in the shelby repo.
Contributor
Author
There was a problem hiding this comment.
imo, we should provide a complete upload function in the sdk that takes care of
- encoding
- registering on chain
- uploading to rpc
we can easily hide those steps from the devs
| @@ -0,0 +1,44 @@ | |||
| import { useWallet } from "@aptos-labs/wallet-adapter-react"; | |||
Contributor
Author
Sure, RPC is currently down so waiting for it and then will record a video
Sure we can, do we have a Shelby Vercel account? |
0xmaayan
force-pushed
the
cross_chain_accounts
branch
from
September 25, 2025 19:58
343670b to
0ba0b47
Compare
0xmaayan
force-pushed
the
cross_chain_accounts
branch
from
September 25, 2025 20:00
0ba0b47 to
10fc9f3
Compare
hariria
approved these changes
Sep 29, 2025
hariria
left a comment
hariria
left a comment
Contributor
There was a problem hiding this comment.
The vercel deployment is a bit annoying.
- You have to use the vercel CLI to publish it (https://vercel.com/docs/cli).
- Then copy the actions i have here: https://github.com/shelby/shelby/tree/main/.github/actions
- Then create a workflow for publishing, see https://github.com/shelby/shelby/blob/main/.github/workflows/ts-preview-creator-studio.yml for an example
0xmaayan
force-pushed
the
cross_chain_accounts
branch
from
September 30, 2025 16:59
b4239c5 to
e75793f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.