Added blob download example - #6
Conversation
fb8350c to
f3c5c9c
Compare
| SHELBY_ACCOUNT_ADDRESS=0x0ab30174c5f0d720e1471bd22579e8d654e02609f753cc246552dc62e6c93d85 | ||
| SHELBY_API_KEY=AG-MR5SFEFY8BSVMEMVG9YETVQBZJJ2QYEPF No newline at end of file |
There was a problem hiding this comment.
Idk if we want to commit this...
There was a problem hiding this comment.
We can stub, yeah. This API key is a default but I can understand the concern.
| const account = AccountAddress.fromString(SHELBY_ACCOUNT_ADDRESS) | ||
|
|
||
| // Away we go! | ||
| async function main() { |
There was a problem hiding this comment.
One nit on linting: i think this is using tabs, can we switch to two spaces to be consistent with the rest of the repo?
There was a problem hiding this comment.
ah, yeah. I thought I ran pnpm fmt but I may have also made an assumption about how it works.
| @@ -0,0 +1,15 @@ | |||
| import { defineConfig } from "tsup" | |||
There was a problem hiding this comment.
Nit: rm, we don't need this
| "@types/node": "^24.3.1", | ||
| "dotenv": "^17.2.2", | ||
| "rimraf": "^6.0.1", | ||
| "tsup": "^8.5.0", |
| "build": "tsup", | ||
| "start": "node dist/index.js", | ||
| "dev": "tsup --watch", | ||
| "clean": "rimraf dist", |
There was a problem hiding this comment.
We can probably replace this with one script that uses tsx to execute. That way we don't need to transpile to javascript. Something like
| "build": "tsup", | |
| "start": "node dist/index.js", | |
| "dev": "tsup --watch", | |
| "clean": "rimraf dist", | |
| "download": "tsx index.ts", | |
| "lint": "biome check .", | |
| "fmt": "biome check . --write", |
Also need lint and fmt scripts
| "os": [ | ||
| "darwin", | ||
| "linux" | ||
| ], |
| @@ -16,10 +16,10 @@ importers: | |||
| version: 2.0.6 | |||
There was a problem hiding this comment.
I'm kind of confused why this caused so many lock changes, can we just double check maayan's example with x-chain accounts is using the same versions as this?
There was a problem hiding this comment.
Yeah, this was confusing for me as well. I could be wrong but I think it's because I forgot to pull main before starting this branch. I rebased from main to end up with this.
Co-authored-by: Andrew Hariri <31301117+hariria@users.noreply.github.com>
affinity-matrix
left a comment
There was a problem hiding this comment.
This is definitely much simpler, but the error output when user neglects to provide env vars is much less intuitive:
/Users/krbn/Source/examples/node_modules/.pnpm/@aptos-labs+ts-sdk@5.1.1_got@11.8.6/node_modules/@aptos-labs/ts-sdk/src/core/accountAddress.ts:385
if (input.startsWith("0x")) {
|
Oh, we also have these issues with |
|
@hariria I'm not familiar enough with the CI process to know how to best fix this. However, now I recall this is why my PR ended up with so many changes to the pnpm-lock file: I had regenerated the file with |
No description provided.