Skip to content

fix(jsx-email): Add react-dom to devDeps#304

Merged
shellscape merged 3 commits into
shellscape:mainfrom
rguarascia:fix/generator-packagejson
Aug 20, 2025
Merged

fix(jsx-email): Add react-dom to devDeps#304
shellscape merged 3 commits into
shellscape:mainfrom
rguarascia:fix/generator-packagejson

Conversation

@rguarascia

@rguarascia rguarascia commented Jun 22, 2025

Copy link
Copy Markdown
Contributor

When trying the starter command pnpm create jsx-email and selecting Typescript, the project fails to run. Adding react-dom fixes this issue

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Current test pass.

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

While running $ pnpm create jsx-email, after successful creation of a project and installing packages via pnpm i running the project with pnpm dev there is an error in the console which prevents the dev env from running. Adding react-dom to the package.json fixed this issue.

Uncaught TypeError: can't access property "ReactCurrentDispatcher", ReactSharedInternals is undefined
    React 2
    __require http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/jsx-email@2.7.2_@jsx-email+plugin-inline@1.0.1_@jsx-email+plugin-minify@1.0.2_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/chunk-BUSYA2B4.js?v=cc0c0df6:3
    dom React
    __require http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/jsx-email@2.7.2_@jsx-email+plugin-inline@1.0.1_@jsx-email+plugin-minify@1.0.2_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/chunk-BUSYA2B4.js?v=cc0c0df6:3
    dom React
    __require http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/jsx-email@2.7.2_@jsx-email+plugin-inline@1.0.1_@jsx-email+plugin-minify@1.0.2_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/chunk-BUSYA2B4.js?v=cc0c0df6:3
    <anonymous> http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/jsx-email@2.7.2_@jsx-email+plugin-inline@1.0.1_@jsx-email+plugin-minify@1.0.2_@jsx-emai_27eb24c976f8ddef97f9f7afecd9af83/node_modules/jsx-email/dist/node_modules/.vite/deps/react-dom_client.js?v=189c18a4:38
[react-dom.development.js:994:30](http://localhost:55420/@fs/Users/ryanguarascia/Documents/Personal/Test/test2/node_modules/.pnpm/react-dom@18.3.1_react@19.1.0/node_modules/react-dom/cjs/react-dom.development.js)
    React 2
    __require chunk-BUSYA2B4.js:3
    js React
    __require chunk-BUSYA2B4.js:3
    js React
    __require chunk-BUSYA2B4.js:3
    <anonymous> react-dom_client.js:38

When trying the starter command `pnpm create jsx-email` and selecting `Typescript`, the project fails to run. Adding react-dom fixes this issue
@shellscape shellscape changed the title [Generator] Add react-dom to devDeps fix(jsx-email): Add react-dom to devDeps Aug 20, 2025

@shellscape shellscape left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@shellscape
shellscape merged commit 3d3c489 into shellscape:main Aug 20, 2025
6 checks passed
shellscape added a commit that referenced this pull request Aug 20, 2025
Co-authored-by: Andrew Powell <shellscape@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants