fix(jsx-email): Add react-dom to devDeps#304
Merged
shellscape merged 3 commits intoAug 20, 2025
Merged
Conversation
When trying the starter command `pnpm create jsx-email` and selecting `Typescript`, the project fails to run. Adding react-dom fixes this issue
shellscape
added a commit
that referenced
this pull request
Aug 20, 2025
Co-authored-by: Andrew Powell <shellscape@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying the starter command
pnpm create jsx-emailand selectingTypescript, the project fails to run. Adding react-dom fixes this issueComponent / Package Name:
This PR contains:
Are tests included?
Current test pass.
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
While running
$ pnpm create jsx-email, after successful creation of a project and installing packages viapnpm irunning the project withpnpm devthere is an error in the console which prevents the dev env from running. Addingreact-domto the package.json fixed this issue.