fix: change build command to use relative paths for output directories#313
Conversation
|
Thanks for getting this up. I want to run it a bit locally tomorrow and then will send it! |
|
Hello @shellscape, were your tests ok? thanks |
|
I put some time in this evening to get Windows tests working. Will be updating your fork with those tests and letting CI run again. The code in your PR passed when running those tests in a branch on my end, so there should be no issue. |
|
Well since I can't push to your PR branch, I'm just going to merge this, but I won't be able to let it release until I can verify the tests. For future reference, this is very helpful for maintainers: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
|
This pull-request breaks the build step on monorepos on Mac
|
|
@semoal I'm using it on mac and don't have an issue. I'll add macos to the testing matrix to be sure. might be an edge specific to your environment. |
|
@semoal test suites run fine on macos - this repository is a pnpm monorepo as well. see: https://github.com/shellscape/jsx-email/actions/runs/18438348627/job/52535111468?pr=317 and https://github.com/shellscape/jsx-email/actions/runs/18438348614/job/52535111485?pr=317. This suggest that it's an issue on your end. If you can create a reproduction, we might be able to get a fix for that, but please continue this discussion in a new issue. |
Component / Package Name: jsx-email
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #307
Description
Fixes CLI command usage on Windows
See comment by @shellscape #307 (comment)