Skip to content

fix: change build command to use relative paths for output directories#313

Merged
shellscape merged 1 commit into
shellscape:mainfrom
ahwootech:fix/jsx-email-preview
Oct 4, 2025
Merged

fix: change build command to use relative paths for output directories#313
shellscape merged 1 commit into
shellscape:mainfrom
ahwootech:fix/jsx-email-preview

Conversation

@AW-Koi

@AW-Koi AW-Koi commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Component / Package Name: jsx-email

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
resolves #307

Description

Fixes CLI command usage on Windows

See comment by @shellscape #307 (comment)

@shellscape

Copy link
Copy Markdown
Owner

Thanks for getting this up. I want to run it a bit locally tomorrow and then will send it!

@aki-matleb

Copy link
Copy Markdown

Hello @shellscape, were your tests ok? thanks

@shellscape

Copy link
Copy Markdown
Owner

I put some time in this evening to get Windows tests working. Will be updating your fork with those tests and letting CI run again. The code in your PR passed when running those tests in a branch on my end, so there should be no issue.

shellscape added a commit that referenced this pull request Oct 4, 2025
@shellscape

Copy link
Copy Markdown
Owner

Well since I can't push to your PR branch, I'm just going to merge this, but I won't be able to let it release until I can verify the tests. For future reference, this is very helpful for maintainers: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@shellscape
shellscape merged commit d236090 into shellscape:main Oct 4, 2025
30 checks passed
@semoal

semoal commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

This pull-request breaks the build step on monorepos on Mac

Error: Cannot find module '/private/var/private/var/folders/70/8rsyw_vj0f5bj3p4hl_sjq600000gn/T/jsx-email/build/advisorInvited-FHKFQPYY.js' imported from /Users/sergiomoreno/Projects/sherpas/node_modules/.pnpm/jsx-email@2.7.4_@emotion+is-prop-valid@1.3.1_@jsx-email+plugin-inline@1.0.1_@jsx-email+_38616f8d9bc8c9129f687dbd008dd5a7/node_modules/jsx-email/dist/esm/cli/commands/build.mjs

@shellscape

Copy link
Copy Markdown
Owner

@semoal I'm using it on mac and don't have an issue. I'll add macos to the testing matrix to be sure. might be an edge specific to your environment.

@shellscape

Copy link
Copy Markdown
Owner

@semoal test suites run fine on macos - this repository is a pnpm monorepo as well. see: https://github.com/shellscape/jsx-email/actions/runs/18438348627/job/52535111468?pr=317 and https://github.com/shellscape/jsx-email/actions/runs/18438348614/job/52535111485?pr=317. This suggest that it's an issue on your end. If you can create a reproduction, we might be able to get a fix for that, but please continue this discussion in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on Windows

4 participants