Bug Fix: Static Edge Type ID Collision in tkgl-smallpedia and tkgl-wikidata#123
Open
JuliaGast wants to merge 4 commits into
Open
Bug Fix: Static Edge Type ID Collision in tkgl-smallpedia and tkgl-wikidata#123JuliaGast wants to merge 4 commits into
JuliaGast wants to merge 4 commits into
Conversation
…tatic edge types, but check if the static edge types are in the temporal edge types and increase id counter if new edge type
…verse edge ids of static edges as well, before assigning the new inverse edge ids
Contributor
Author
|
Commit: a9ba593 Previously, when assigning edge IDs for static edges, we started the new IDs at This update changes the starting ID for new static edges to |
…d when doing a per-query prediction. this ensures to reach mrrs reported in original paper for icews14/18. it seems not to impact yago and wiki-based datasets
…r. this does not significantly affect the final mrr in my experiments, but might be important for further experiments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (before PR):
When preprocessing static edges for (tkgl-smallpedia and tkgl-wikidata), the original code assigned static edge type IDs starting from 0.
As a result:
This caused inconsistent edge type mappings.
Affected datasets:
tkgl-smallpediatkgl-wikidataFix: