Repository navigation
[MASTER] refactor: move the UI into a specific folder - #26
Conversation
0d0cf60 to
a876764
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a876764. Configure here.
Route handlers send any resolved shineRequest value as HTTP 200, so a missing Axios response was shown as successful output.
|
|
||
| export const shineRequest = isPublicAPI ? publicApiRequest : regulatedRequest; | ||
|
|
||
| export const convertObjectToString = (payload: unknown) => { |
There was a problem hiding this comment.
There seems to be a circular import here (publicApiRequest.ts imports this function from index.ts and index.ts imports publicApiRequest().
Claude tells me that this is not an issue currently because of the tsconfig file and the module: esnext flag, but I still think it might be better to put this in its own utils.ts or convertObjectToString.ts file to completely prevent any future issue that might arise when editing this code.
There was a problem hiding this comment.
Taking a step back and realizing the purpose of this repo, it might not be a huge issue either 🫣
I'll approve this and let you be the judge and make the change if you feel like it's needed.
There was a problem hiding this comment.
oh yes it's an example of Shine connect integration 🤣

I moved the ui into a specific folder to be able to use the example in different environments
Note
Medium Risk
Touches regulated/public API request paths and mTLS request setup (including removal of commented CA config); behavior changes are mostly defensive but affect how API errors propagate to the UI.
Overview
Reorganizes the demo UI under
app/and shared helpers underlib/utils, updating imports (e.g.pages/index.tsx→app/containers/App) so the example can be run in different environments.Enables
strictNullChecksand aligns React state /FeatureParamstypes (string | null, optional auth state). Feature components now surface axios failures safely viaerr.response?.data ?? err.message.Server-side:
convertObjectToStringis centralized inserver/request/index.tsfor public and regulated clients;publicApiRequesthandles missing responses;regulatedRequestguardscontent-typeparsing;main.tsvalidatesredirectUripathname. Addsrun:prod, ignores localconfig.json/ example configs in.gitignore, and bumpsqsin the lockfile.Reviewed by Cursor Bugbot for commit 0dc575d. Bugbot is set up for automated code reviews on this repo. Configure here.