Echo the companion state nonce through the authorize flow - #169
Merged
Conversation
The desktop companion opens /companion/authorize with an anti-CSRF state nonce, but the minutia:// callback dropped it, forcing the client to accept state-less callbacks. The authorize client now threads state from the incoming query through to the deep link (percent-encoded exactly once, omitted entirely when absent so older companion builds see a byte-identical URL). State survives the signed-out login round-trip by riding the existing next param; covered at unit and e2e level, including hostile-character encoding and safeAuthNextPath passthrough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop companion sends an anti-CSRF
statenonce when opening/companion/authorize, but theminutia://auth-callbackdeep link dropped it, so the desktop must accept state-less callbacks. This threadsstatefrom the incoming query through to the callback URL.encodeURIComponent; hostile characters (&,=,#, spaces) cannot smuggle params or break the URL.nextparam (middleware, login, /auth/callback untouched).Unblocks the companion dropping nil-state acceptance in a follow-up desktop release. Two independent reviews (spec + security): no findings.