[codex] Remove Sentry disable path#11
Merged
Merged
Conversation
seslly
force-pushed
the
codex/sentry-steamcmd-update-fix
branch
from
April 30, 2026 16:29
13863e1 to
76ae440
Compare
seslly
changed the title
seslly
marked this pull request as ready for review
April 30, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISABLE_SENTRYruntime/config surface from compose, bare Linux, Helm values, and Helm templatesWindowsServer/tree is left intactSentrytoSentry.DISABLED, move it back so SteamCMD can validate and patch cleanlyWhy
The old workaround renamed
WindowsServer/R5/Plugins/3rdParty/Sentryto avoid earlier Crashpad/Proton failures. That mutated SteamCMD-owned files, and Windrose's April 30, 2026 server patch then failed validation because Steam expected the bundled Sentry files to exist.We do not need a continuing Sentry disable feature. The safe behavior is to stop touching that plugin, while healing installs that were already affected by older images.
Validation
bash -n scripts/entrypoint.sh bare-linux/install.shgit diff --check origin/main...HEADhelm template windrose ./helm/windrosergconfirms the only remaining Sentry references are the legacySentry.DISABLEDrestore path inscripts/entrypoint.shShellCheck is not installed in the local WSL environment, so it was not run locally.