[codex] Fix Direct IP disabled port validation#12
Merged
Conversation
seslly
marked this pull request as ready for review
April 30, 2026 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DirectConnectionServerPort: -1sentinel whenUseDirectConnectionis disabled-1when Direct IP is enabled, so enabled Direct IP still requires a real UDP port-1, enabled-1, and the existing out-of-range port casesWhy
Issue #10 reports that fresh installs can load a default server config with
DirectConnectionServerPort: -1. The admin UI preserved that value when staging unrelated config changes, but the server schema rejected anything outside1..65535. That made simple edits like changingServerNamefail with HTTP 400 while appearing as a no-op in the UI.Validation
python3 tests/test_schema.pypython3 -m py_compile server.py tests/test_schema.pynode --check ui/app.jspytest -q tests(68 passed)git diff --checkFixes #10.