Fix road generation success when no RoadData is produced - #91
Open
ErikSteiner wants to merge 1 commit into
Open
ErikSteiner wants to merge 1 commit into
ErikSteiner wants to merge 1 commit into
Conversation
ErikSteiner
force-pushed
the
fix/generation-status-contract
branch
from
August 26, 2026 09:40
fbcfdef to
736eddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a generation-status inconsistency in
RoadGenerationService.generateTask().Road.generateRoad()can legitimately returnnull, butgenerateTask()previously discarded that return value and reported success as long as no exception was thrown.safeGenerate()could therefore mark aStructureConnectionasCOMPLETEDeven though noRoadDatahad been produced.Changes
Road.generateRoad() == nullas an unsuccessful generation attempt.nullpath.commonmodule.The production change is intentionally minimal:
Existing exception handling and the existing behavior when roads are globally disabled are unchanged.
Testing
expected false but was true).Road.generateRoad()returnnull.:common:test --rerun-tasks:BUILD SUCCESSFUL(1/1 tests).git diff --check: clean.generateRoad() == nullcondition was not observed during the manual smoke test.Scope
This PR only addresses the incorrect success contract around
Road.generateRoad().It does not change:
RoadDatais persisted and a later precomputation step failsDevelopment tracking:
ErikSteiner#1