fix: dialog reentrancy guard and settings-dialog Escape contract#18
Merged
Conversation
DialogManager.show() now raises RuntimeError if a dialog is already open. Previously a second show() overwrote _current_dialog, orphaning the first dialog's result future — its awaiter hung forever with no way to resolve. Failing loudly makes the single-dialog contract explicit. SettingsDialog with can_cancel=False now disables Escape (_UNSET) instead of setting escape_result to the string "close", which leaked through DialogManager.show() as the return value of show_settings_dialog() — violating its documented dict-or-None contract (callers iterating result.items() would crash on a str). With no cancel concept, the Done button is the only way out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DialogManager.show()raisesRuntimeErrorif a dialog is already open. Previously a secondshow()overwrote_current_dialog, orphaning the first dialog's result future — its awaiter hung forever with no way to resolve. Failing loudly makes the single-dialog contract explicit.SettingsDialog(can_cancel=False)disables Escape (_UNSET) instead of settingescape_resultto the string"close", which leaked throughDialogManager.show()as the return value ofshow_settings_dialog()— violating its documenteddict | Nonecontract (callers iteratingresult.items()would crash on a str). With no cancel concept, the Done button is the only way out.Tests
show()raises; the first dialog is unaffected and still resolvable.can_cancel=True→None;can_cancel=False→_UNSET(escape disabled).Identified in docs/notes/project_review_20260612.md (findings 3 and 4).