docs: sync-handler event-loop warning; changelog for pending fixes#21
Merged
Conversation
Document that synchronous input handlers run on the event loop and freeze the UI (including Ctrl+C handling) until they return — in the README quick start and the on_input/run_async docstrings. Add Unreleased changelog entries covering the Ctrl+C idle-exit fix, dialog lifecycle fixes, thinking-box polish, and the rich_utils refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
on_input/run_asyncdocstrings now state explicitly that synchronous input handlers run on the event loop — the UI freezes and Ctrl+C is not processed until they return. Recommends async handlers withasyncio.to_threadfor blocking work.[Unreleased]changelog section covering PRs fix: first Ctrl+C at idle prompt exits instead of zombifying the session #17–refactor: extract rich_utils; stop monkey-patching Rich's Markdown globally #20, including theprompt_async()behavior-change disclosure from the review of fix: first Ctrl+C at idle prompt exits instead of zombifying the session #17 (Ctrl+C at idle now also callsapp.exit()for directprompt_async()consumers).Version bump to 0.3.3 is deliberately left for release time.