fix(dump): resolve old faker replacements, fixes #799 #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #799 by adding logic to wrap old bare faker expressions (e.g., faker.Internet().Email()) with the required delimiters ({{- -}}) before evaluation. This ensures backward compatibility with database values that were stored before the delimiter requirement was introduced.
Key changes:
- Added wrapping logic for bare faker expressions in the data dumping process
- Added a test case to validate faker expression evaluation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/mysqldump/mysql.go | Added conditional logic to detect and wrap bare faker expressions with delimiters before processing |
| internal/mysqldump/faker_test.go | Added test case for validating faker expression evaluation (though it doesn't test the new wrapping logic directly) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shyim
force-pushed
the
fix/faker
branch
2 times, most recently
from
117fc89 to
e476a7d
Compare
Normalize faker expressions at config level by wrapping bare expressions
like "faker.Internet.Email()" with {{- -}} delimiters before they're
used in the dump process. This approach handles the normalization in one
place (NormalizeFakerExpressions) rather than at runtime.
- Add NormalizeFakerExpressions method to ConfigDump
- Call normalization after reading config in project_dump.go
- Add comprehensive tests for the new normalization logic
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.