Skip to content

Conversation

@shyim
Copy link
Member

@shyim shyim commented Jan 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 9, 2026 09:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where the Vite entrypoints manifest would reference a CSS file even when it doesn't exist. The fix checks for the CSS file's existence before including it in the manifest.

Key changes:

  • Added logic to check if the CSS file exists before including it in the entrypoints.json manifest
  • Updated existing test to create the CSS file explicitly when testing the case where CSS should be included
  • Added a new test to verify the behavior when no CSS file exists

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/esbuild/vite_config.go Added filepath import and CSS file existence check that removes the CSS entry from entrypoints when the file doesn't exist
internal/esbuild/vite_config_test.go Modified TestDumpViteEntrypoint to create CSS file explicitly, and added TestDumpViteEntrypointNoCssFile to test the no-CSS-file scenario

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shyim shyim merged commit 38311c1 into main Jan 9, 2026
10 checks passed
@shyim shyim deleted the fix/vite-manifest-404-file branch January 9, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants