fix(debug): usable file-type select, formatted Monaco, drop entrypoints strip - #64
Merged
Merged
Conversation
Switch File type and Pipeline filters to NativeSelect so scrolling the menu no longer closes it (mui-lite#2). Pretty-print JSON and format Monaco snapshots, and drop the entrypoints strip above the editor.
Contributor
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying frame-master-docs with
|
| Latest commit: |
f06de8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://24bf32ce.frame-master-docs.pages.dev |
| Branch Preview URL: | https://fix-debug-ui-select-format.frame-master-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debug web UI polish for three issues found while inspecting traces.
SelecthardcodescloseOnScrolland itsMenutreats the dropdown’s own overflow as a page scroll (shpaw415/mui-lite#2). This PR workarounds with outlinedNativeSelectso the native popup stays open while scrolling.formatDocumentafter mount (best-effort, invalid snapshots stay raw). Raw byte sizes in the diff bar are unchanged.DX
Inspecting a build no longer fights the type filter, and transform output is readable instead of a single minified line. The editor workspace is no longer crowded by every pipeline entrypoint path.
Test plan
bun run typecheckinpackages/frame-masterbun test test/format-debug-source.test.ts test/debug-ui-state.test.tsbun run build:tool:debugRelated: shpaw415/mui-lite#2