Repository navigation
chore(checker): age-proof third-party subresource failure wording - #85
Merged
Merged
Conversation
The third-party subresource failures said "approved analytics host", which reads oddly when the violator is a font or CSS URL. Say "explicitly allowed host" so the wording survives ANALYTICS_HOSTS growing non-analytics entries. Review follow-up on #84: checker OK 9 checks; full check-site test section passes (the 50 unrelated daemon-test failures are pre-existing on this Linux box — macOS launchd/Tailscale dependent, not touched by this change). Co-Authored-By: Claude Code <noreply@anthropic.com>
shrwnsan
force-pushed
the
checker-wording-fix
branch
from
October 14, 2026 14:01
057b341 to
a0a4987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-up on #84 (fix authored during review but the PR merged via squash before it could be pushed).
The third-party subresource failure strings said "approved analytics host", which reads oddly when the violator is a font or CSS URL. Now "explicitly allowed host", so the wording survives
ANALYTICS_HOSTSgrowing non-analytics entries. No behavior change —ANALYTICS_HOSTSitself is untouched.python3 scripts/check-site.py→ OK 9 checkstests/test-check-site.shsection: all passCo-authored-by: Claude Code (review pass on oci-prime box).