Repository navigation
feat(files): the File Manager sorts by Name, Size or Modified when you click a header — GH #1184 - #1995
Merged
Conversation
…u click a header — GH #1184 The commit that added this sat on the gh1184-admin-fm-reuse-tenant branch after its PR merged without it. The columns get antd sorters; until a header is clicked the listing keeps its default order (folders first, then by name). The listing is not paginated, so the sort covers the whole folder. Playwright spec file-manager-sort.spec.ts: default order, then Name, Size and Modified each reorder the rows. It fails on main without the sorters. Claude-Session: https://claude.ai/code/session_0173PcNd4h6NceYPc4FuhvXj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The File Manager's Name, Size and Modified columns now sort when you click a header. Until a header is clicked, the listing keeps its default order: folders first, then by name. The listing isn't paginated, so a sort covers the whole folder.
This commit was written for GH #1184, the admin File Manager. It stayed on that branch after the branch's PR merged without it, and a branch cleanup on 2026-10-04 turned it up.
FileManagerPage.tsx: antdsorteron the three columns (5 lines).file-manager-sort.spec.ts: checks the default order, then that Name, Size and Modified each reorder the rows. Falsified: it fails on main without the sorters.https://claude.ai/code/session_0173PcNd4h6NceYPc4FuhvXj