feat(dns): one zone list — the name opens its records, and DNSSEC lives in the row's ⋯ menu — GH #1918 - #2000
Merged
Merged
Conversation
…es in the row's ⋯ menu — GH #1918 johnnyq asked to merge the Zones and DNSSEC tabs. The DNS page (admin and tenant) is now one list: - The domain name links to the zone's records, so the Manage Records button is gone. A row whose DNS is hosted elsewhere keeps a plain name and its Enable DNS button. - The row's ⋯ menu holds Enable / Disable DNSSEC, View DS & keys (signed zones), and Delete zone or Delete domain. A signed zone's delete stays disabled with the "disable DNSSEC first" hint. - Disable DNSSEC now confirms first. The old tab's switch turned signing off in one click, and doing that while the registrar still publishes the DS makes validating resolvers reject the zone. - View DS & keys opens a modal with the keys (type, tag, algorithm, state) and the DS records. The admin signing note moved there. DNSSEC is flipped through a new useSetDNSSEC hook. It takes the domain at call time, since the menu is built per row, and it refreshes the zone list so the Signed tag follows. The DNSSECTable component and the old per-id hook are removed. Docs: dns.md, admin/dns-zones.md, user/dnssec.md and platform/dnssec.md now describe the menu (the user and platform docs still pointed at a Domain Edit toggle that no longer exists). Claude-Session: https://claude.ai/code/session_0173PcNd4h6NceYPc4FuhvXj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH #1918 (johnnyq): merge the DNS page's Zones and DNSSEC tabs. Clicking the domain name opens its records, and the DNSSEC actions and the zone delete move into a ⋯ menu.
What changes (admin and tenant DNS page)
?tab=dnsseclinks and the existing/dnssecredirects land on the list.<Link>with an href, so middle-click works. The Manage Records button is gone.Behavior changes beyond layout
PUT /domains/:id/dnssecrunspdnsutilon the zone, so it failed there anyway. A signed row always offers Disable, so a stuck state can still be cleared.useSetDNSSEC, which takes the domain at call time and also refreshes["list","dns/zones"]so the Signed tag follows.DNSSECTableand the per-iduseUpdateDNSSECare removed (no other users).Docs
dns.md,admin/dns-zones.md,user/dnssec.mdandplatform/dnssec.mdnow describe the menu. The user and platform pages still pointed at a Domain Edit DNSSEC toggle that no longer exists.Tests
DNSZoneInventory.test.tsx(12 tests):useDNSSEC.test.tsx: the PUT targets the domain given at call time and invalidates the zone list (prefix match), with unrelated keys untouched.tests/e2e/dns-zone-menu.spec.ts(Chromium, built SPA, mocked API):tsc -b, eslint (0 errors), and the Playwright spec.https://claude.ai/code/session_0173PcNd4h6NceYPc4FuhvXj