Skip to content

Comments

Move Docker demo to examples/docker, simplify README#100

Merged
nicosuave merged 1 commit intomainfrom
nicosuave/move-docker-demo
Feb 21, 2026
Merged

Move Docker demo to examples/docker, simplify README#100
nicosuave merged 1 commit intomainfrom
nicosuave/move-docker-demo

Conversation

@nicosuave
Copy link
Member

Moves Docker configuration and documentation to examples/docker/, making the main README more concise and focusing users on the published sidequery/sidemantic image on Docker Hub.

Changes:

  • Moved docker-compose.yml to examples/docker/ (integration test infrastructure)
  • Created examples/docker/README.md with comprehensive Docker usage documentation
  • Simplified main README Docker section to focus on the published image
  • Clarified volume mount requirements and ADBC connection method

The Dockerfile and docker-entrypoint.sh remain at root for CI/CD pipeline compatibility.

- Move docker-compose.yml to examples/docker (integration test infra)
- Add examples/docker/README.md with detailed Docker usage docs
- Trim main README Docker section to prioritize published sidequery/sidemantic image
- Clarify volume mount requirement and ADBC connection method
@nicosuave nicosuave merged commit d642cce into main Feb 21, 2026
14 checks passed
@nicosuave nicosuave deleted the nicosuave/move-docker-demo branch February 21, 2026 20:06
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review


P2 Badge Preserve root compose path for existing test workflows

Moving docker-compose.yml into examples/docker/ without leaving a root-level entrypoint breaks existing repo instructions that still run docker compose up ... without -f (for example tests/db/README.md uses that form at lines 18, 21, 57, 87, and 99). Those commands previously worked from the repository root but now cannot find a compose file, so local integration-test setup regresses unless every caller is updated to pass -f examples/docker/docker-compose.yml (or a compatibility file is kept at root).

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant