Fix 8 findings from independent code audit - #99
Merged
Merged
Conversation
Reject spoofed SNTP replies (connect() the UDP socket to the resolved server), feed keystroke timing into the entropy pool from the GUI's own passphrase requester, fix a ReAction gadget-tree leak on window-creation failure across four requesters, zero key-derived scratch buffers in HMAC/PBKDF2, validate the vault's per-account digits field, zero a decoded secret on a CLI vault-open failure, and fix a NULL-check ordering bug in the QR decode wrapper. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/AUDIT_2026-07.mddigitsfield unvalidated; CLI secret not zeroed on vault-open failure; QR decode NULL-check orderingTest plan
make test— 292/292 passingmake m68k-docker gui-docker— clean cross-build, no warningsuserdocs/updates needed (seedocs/AUDIT_2026-07.mdfor per-finding detail)🤖 Generated with Claude Code