Implement AllocDosObject/FreeDosObject's DOS_FIB type - #90
Merged
Merged
Conversation
DOS_FIB just needs a zeroed sizeof(struct FileInfoBlock) block, same shape as the already-implemented DOS_RDARGS/DOS_EXALLCONTROL cases (confirmed against the NDK 3.2 AllocDosObject autodoc) -- reuses doslock::FIB_SIZE rather than a second, possibly-drifting copy of the constant. Found running the real sidick/micropython Amiga port: its os.walk() allocates its own FileInfoBlock this way (instead of using ExAll), and previously hit "AllocDosObject(type=2): only DOS_RDARGS (5) and DOS_EXALLCONTROL (1) are implemented". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CjVfTPHtTpowd7YqhcjXJW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllocDosObject(DOS_FIB, ...)is just a zeroedsizeof(struct FileInfoBlock)block per the NDK 3.2 autodoc, the same shape as the already-implementedDOS_RDARGS/DOS_EXALLCONTROLcases -- reusesdoslock::FIB_SIZE(260 bytes, independently verified against<dos/dos.h>'s field layout) rather than a second copy of the constant.sidick/micropythonAmiga port'sos.walk(), which allocates its ownFileInfoBlockthis way (instead of usingExAll) and previously hitAllocDosObject(type=2): only DOS_RDARGS (5) and DOS_EXALLCONTROL (1) are implemented.Test plan
cargo test— all 858 tests pass (2 new: alloc/free round-trip + zeroed-block check forDOS_FIB)examples/volume_listing.py(which exercisesos.walk()) now runs end-to-end under volamos🤖 Generated with Claude Code
https://claude.ai/code/session_01CjVfTPHtTpowd7YqhcjXJW