Fix SetVar to succeed silently on a missing variable - #91
Merged
Merged
Conversation
Real SetVar(name, NULL, 0, flags), and DeleteVar which is implemented in terms of it, succeed silently when the variable doesn't exist (verified against real Kickstart via Copperline). Both the local-vars path and the ENV:-backed global path were wrongly returning ERROR_OBJECT_NOT_FOUND instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetVar(name, NULL, 0, flags)on a nonexistent variable now succeeds silently instead of returningERROR_OBJECT_NOT_FOUND, both for local vars andENV:-backed global vars.DeleteVar(implemented on top ofSetVar) inherits the fix.Test plan
cargo test -p volamos-core dosvar— 14 tests pass, including two new ones for the missing-var-delete case (local and global)🤖 Generated with Claude Code