Skip to content

Fix(MockCA, Batch): Fix PVNO Setting Batch PKIMessage Responses - #78

Merged
ralienpp merged 6 commits into
siemens:mainfrom
Guiliano99:FixBatchPVNO2
Apr 14, 2026
Merged

Fix(MockCA, Batch): Fix PVNO Setting Batch PKIMessage Responses#78
ralienpp merged 6 commits into
siemens:mainfrom
Guiliano99:FixBatchPVNO2

Conversation

@Guiliano99

Copy link
Copy Markdown
Contributor

Fix the NestedHandler so that responses to nested and batch PKIMessages
correctly mirror the sender's pvno value, as required by RFC 9483 Section 3.1.
Add Robot Framework and unit tests to verify the behaviour across all relevant scenarios.

Description

  • Pass pvno=request["header"]["pvno"] when constructing the response PKIMessage
    in NestedHandler.handle_nested_message() so the response reflects the
    sender's protocol version.
  • Add Robot Framework test CA MUST Respond with A Correct PVNO For Inner Added Protection verifying that an added-protection nested message with pvno=3
    receives a response with pvno=3.
  • Add Robot Framework tests for batch messages: outer pvno=3 / inner pvno=2,
    reversed (pvno=2 / pvno=3), and mixed inner pvno values (2, 3, 2).
  • Extend _generate_nested_message() in test_process_batch_message.py with
    explicit pvno values and add assertions that both the outer response and
    individual inner responses carry the correct pvno.

Motivation and Context

  • Fix implementation.
  • Added missing test cases.

How Has This Been Tested?

  • Run the Robot Framework test suite (tests/pki_mgmt_entity_op.robot) covering
    added-protection nested messages and batch messages with uniform, reversed, and
    mixed pvno configurations.

@Guiliano99
Guiliano99 marked this pull request as ready for review April 13, 2026 17:03
@ralienpp
ralienpp merged commit d35c9de into siemens:main Apr 14, 2026
8 of 10 checks passed
@Guiliano99
Guiliano99 deleted the FixBatchPVNO2 branch April 14, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants