Fix(MockCA, Batch): Fix PVNO Setting Batch PKIMessage Responses - #78
Merged
Conversation
… outer batch PKIMessage version.
…ch messages, which includes mixed versions.
Guiliano99
marked this pull request as ready for review
April 13, 2026 17:03
ralienpp
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
NestedHandlerso that responses to nested and batch PKIMessagescorrectly mirror the sender's
pvnovalue, as required by RFC 9483 Section 3.1.Add Robot Framework and unit tests to verify the behaviour across all relevant scenarios.
Description
pvno=request["header"]["pvno"]when constructing the response PKIMessagein
NestedHandler.handle_nested_message()so the response reflects thesender's protocol version.
CA MUST Respond with A Correct PVNO For Inner Added Protectionverifying that an added-protection nested message withpvno=3receives a response with
pvno=3.pvno=3/ innerpvno=2,reversed (
pvno=2/pvno=3), and mixed innerpvnovalues (2, 3, 2)._generate_nested_message()intest_process_batch_message.pywithexplicit
pvnovalues and add assertions that both the outer response andindividual inner responses carry the correct
pvno.Motivation and Context
How Has This Been Tested?
tests/pki_mgmt_entity_op.robot) coveringadded-protection nested messages and batch messages with uniform, reversed, and
mixed
pvnoconfigurations.