Skip to content

fix(search): move focus ring to the search form container #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GautamVhavle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(search): move focus ring to the search form container #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/scss/overwrite/_searchBar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,16 @@
--aa-primary-color-rgb: var(--theme-color-std-text);
color: var(--theme-color-std-text);

// The search field is only one part of the form, so the focus ring belongs on
// the whole form. Otherwise it is drawn inside the form and overlaps its
// border, the submit icon and the clear button.
// `!important` is required because autocomplete.js resets the outline with an
// equally specific rule that is loaded later.
&:focus-within {
outline: 1px solid var(--theme-color-focus-bdr) !important;
outline-offset: var(--theme-focus-outline-offset);
}

.aa-InputWrapperSuffix,
.aa-InputWrapperPrefix {
background-color: var(--theme-input--background);
Expand All @@ -55,6 +65,13 @@
box-shadow: none;
}

// Wins over the global `input:focus` rule from `@siemens/ix`.
.aa-Input:focus,
.aa-Input:focus-visible {
outline: none !important;
box-shadow: none !important;
}

.aa-Input::placeholder {
color: var(--theme-color-soft-text);
}
Expand Down
Loading