Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/.vitepress/config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export default withMermaid(
socialLinks: [
{icon: 'github', link: 'https://github.com/sign/translate'},
{icon: 'x', link: 'https://x.com/signmt_'},
{icon: 'linkedin', link: 'https://www.linkedin.com/company/sign-mt'},
{icon: 'linkedin', link: 'https://www.linkedin.com/company/rylohq/'},
],
},
head: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ <h3>{{ t('title') }}</h3>
<div class="social">
<h3>Find Us</h3>
<ul>
<li><a href="https://x.com/NagishSign" target="_blank">Twitter (X)</a></li>
<li><a href="https://www.linkedin.com/company/sign-mt" target="_blank">LinkedIn</a></li>
<li><a href="https://x.com/rylohq" target="_blank">Twitter (X)</a></li>
<li><a href="https://www.linkedin.com/company/rylohq/" target="_blank">LinkedIn</a></li>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add rel="noopener noreferrer" for external links opened in new tabs.

target="_blank" without rel="noopener noreferrer" exposes reverse-tabnabbing risk. Please add rel on this link (and keep it consistent for sibling external links in this list).

Suggested patch
-        <li><a href="https://www.linkedin.com/company/rylohq/" target="_blank">LinkedIn</a></li>
+        <li><a href="https://www.linkedin.com/company/rylohq/" target="_blank" rel="noopener noreferrer">LinkedIn</a></li>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<li><a href="https://www.linkedin.com/company/rylohq/" target="_blank">LinkedIn</a></li>
<li><a href="https://www.linkedin.com/company/rylohq/" target="_blank" rel="noopener noreferrer">LinkedIn</a></li>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/pages/landing/landing-footer/landing-footer.component.html` at line
28, The external anchor in landing-footer.component.html (the <a
href="https://www.linkedin.com/company/rylohq/" target="_blank">LinkedIn</a>
element) must include rel="noopener noreferrer" to mitigate reverse-tabnabbing;
update that anchor and any other sibling external links in the same list that
use target="_blank" to add rel="noopener noreferrer" so the behavior is
consistent across the component.

<li><a href="https://github.com/sign" target="_blank">GitHub</a></li>
</ul>
</div>
Expand Down
Loading