Fix archive URL detection using explicit HTTP status check#305
Open
Fix archive URL detection using explicit HTTP status check#305
Conversation
Replace curl -f exit code check with explicit %{http_code} comparison
to reliably detect whether the new _mcp_ archive exists for a release.
The previous --head check gave false positives on Linux due to redirect
chain behavior, causing installs to fail with 404 for older releases.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl -fexit code check with an explicit%{http_code}comparison to detect whether the new_mcp_archive exists for a given release--headcheck gave false positives on Linux due to redirect chain behavior, causing the install script to attempt downloading a non-existent URL and fail with 404 for older releasesTest plan
SIGNADOT_CLI_VERSION=v1.4.0) and verify it falls back to the old naming scheme_mcp_archives and verify it uses the new URL🤖 Generated with Claude Code