This repository was archived by the owner on Feb 3, 2022. It is now read-only.
Trivially update commit payout image path FREEBIE#37
Open
liliakai wants to merge 1 commit intosignalapp:masterfrom
Open
Trivially update commit payout image path FREEBIE#37liliakai wants to merge 1 commit intosignalapp:masterfrom
liliakai wants to merge 1 commit intosignalapp:masterfrom
Conversation
Contributor
|
merge conflict! can you rebase? |
Bithub is now serving the payout image with Cache-Control: max-age=0 but github/fastly is still serving the old cached image. My theory is that it is not re-reading the headers correctly, although it may be a bug with github's fastly configuration, since they probably don't expect anyone to be serving dynamic content in their READMEs. This commit simply adds a trailing / to the image path, which effectively forces fastly to re-fetch the image. Hopefully this time it will read (and respect) the Cache-Control header.
Author
|
re re re re base base base base d d d d |
Contributor
|
geez i'm pretty slow on the draw here. do we still need to do this or have the caches caught up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bithub is now serving the payout image with Cache-Control: max-age=0 but github/fastly is still serving the old cached image on READMEs for Bithub, TextSecure, etc... Evidently fastly is not re-reading the headers correctly.
This commit simply adds a trailing / to the image path, which changes the url hash and effectively forces fastly to re-fetch the image and its headers. I've confirmed that the README in my fork is no longer caching the image.