merge queue: checking epbs (01f19c4) and #1215 together - #1225
Closed
mergify[bot] wants to merge 5 commits into
Closed
merge queue: checking epbs (01f19c4) and #1215 together#1225mergify[bot] wants to merge 5 commits into
mergify[bot] wants to merge 5 commits into
Conversation
…ign_attestations to SingleAttestation Bump the Lighthouse pin from 81d576943 to e58ec88fe (EIP-7688 merge) and adapt to the interface changes in the window: - Mirror Lighthouse's six EIP-7688 [patch.crates-io] git pins into the root workspace so the patched SSZ stack applies. - Migrate the validator_store attestation path to the de-generified AttestationToSign / SingleAttestation interface (LH #9578), with duty-identity checks that withhold mismatched duties from publication without stalling the committee's exact-count signature collection. - Add fork-aware decode helpers on DataVersion (EIP-7688 progressive shapes at Gloas, Heze fails closed) and bind leader-supplied versions to our own candidate in both aggregator validators (SIP-94). - Merkleize BlindedExecutionPayloadEnvelope as a progressive container to preserve blinded/full root parity at the new pin (SIP-94). - Fill Heze DataVersion arms and adopt the EnrExt dialable_multiaddrs rename. Closes #1214
# Conflicts: # Cargo.lock # Cargo.toml
…ty-mismatch attestations
…of withholding The duty's attester_index/committee_index are not part of the signing root and the beacon node validates them authoritatively on publish, so a true mismatch cannot land on chain, while withholding could suppress a valid attestation whenever the slot-start snapshot went stale mid-slot (dependent-root change). The comparison stays as a diagnostic: warn for attester_index mismatches (indices are permanent, so always a real fault), info for committee drift, plus a reason-labelled anchor_attestation_duty_identity_mismatches_total counter. Removes AttestationCandidate, the publishable flag, and the withheld metrics label; every slash-safe attestation is returned for publication and slashing-DB recording is unchanged.
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## epbs #1225 +/- ##
==========================================
+ Coverage 69.67% 70.11% +0.44%
==========================================
Files 165 166 +1
Lines 32475 32959 +484
==========================================
+ Hits 22626 23109 +483
- Misses 9849 9850 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch epbs (01f19c4) and #1215 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #1215.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success=cli-reference-checkcheck-success=run-local-testnetcheck-success=test-suite-successRequired conditions to stay in the queue:
#approved-reviews-by >= 1check-success=license/clacheck-success=target-branch-checklabel!=do-not-merge