Skip to content

merge queue: checking epbs (01f19c4) and #1215 together - #1225

Closed
mergify[bot] wants to merge 5 commits into
epbsfrom
mergify/merge-queue/8fd49cb9d0
Closed

merge queue: checking epbs (01f19c4) and #1215 together#1225
mergify[bot] wants to merge 5 commits into
epbsfrom
mergify/merge-queue/8fd49cb9d0

Conversation

@mergify

@mergify mergify Bot commented Aug 7, 2026

Copy link
Copy Markdown

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch epbs (01f19c4) and #1215 are queued together for merge.

This pull request has been created by Mergify to check the mergeability of #1215.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

  • check-success=cli-reference-check
  • check-success=run-local-testnet
  • check-success=test-suite-success

Required conditions to stay in the queue:

---
checking_base_sha: 01f19c49c20ec515a25d27084699b0885d68b377
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 1215
    scopes: []
scopes: []
...

shane-moore and others added 5 commits August 4, 2026 15:00
…ign_attestations to SingleAttestation

Bump the Lighthouse pin from 81d576943 to e58ec88fe (EIP-7688 merge) and
adapt to the interface changes in the window:

- Mirror Lighthouse's six EIP-7688 [patch.crates-io] git pins into the
  root workspace so the patched SSZ stack applies.
- Migrate the validator_store attestation path to the de-generified
  AttestationToSign / SingleAttestation interface (LH #9578), with
  duty-identity checks that withhold mismatched duties from publication
  without stalling the committee's exact-count signature collection.
- Add fork-aware decode helpers on DataVersion (EIP-7688 progressive
  shapes at Gloas, Heze fails closed) and bind leader-supplied versions
  to our own candidate in both aggregator validators (SIP-94).
- Merkleize BlindedExecutionPayloadEnvelope as a progressive container
  to preserve blinded/full root parity at the new pin (SIP-94).
- Fill Heze DataVersion arms and adopt the EnrExt dialable_multiaddrs
  rename.

Closes #1214
…of withholding

The duty's attester_index/committee_index are not part of the signing
root and the beacon node validates them authoritatively on publish, so
a true mismatch cannot land on chain, while withholding could suppress
a valid attestation whenever the slot-start snapshot went stale
mid-slot (dependent-root change).

The comparison stays as a diagnostic: warn for attester_index
mismatches (indices are permanent, so always a real fault), info for
committee drift, plus a reason-labelled
anchor_attestation_duty_identity_mismatches_total counter. Removes
AttestationCandidate, the publishable flag, and the withheld metrics
label; every slash-safe attestation is returned for publication and
slashing-DB recording is unchanged.
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Your PR title doesn't follow the Conventional Commit guidelines.

Example of valid titles:

  • feat: add new user login
  • fix: correct button size
  • docs: update README

Usage:

  • feat: Introduces a new feature
  • fix: Patches a bug
  • chore: General maintenance tasks or updates
  • test: Adding new tests or modifying existing tests
  • perf: Performance improvements
  • refactor: Changes to improve code structure
  • docs: Documentation updates
  • ci: Changes to CI/CD configurations
  • revert: Reverts a previously merged PR

Breaking Changes

Breaking changes are noted by using an exclamation mark. For example:

  • feat!: changed the API
  • chore(node)!: Removed unused public function

Help

For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.59016% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.11%. Comparing base (01f19c4) to head (4cd09e5).

Files with missing lines Patch % Lines
anchor/common/ssv_types/src/consensus.rs 95.55% 14 Missing ⚠️
anchor/validator_store/src/lib.rs 77.19% 13 Missing ⚠️
...tore/src/testing/committee_attestation_slashing.rs 97.85% 3 Missing ⚠️
anchor/network/src/peer_manager/discovery.rs 0.00% 2 Missing ⚠️
anchor/spec_tests/src/utils/error_codes.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             epbs    #1225      +/-   ##
==========================================
+ Coverage   69.67%   70.11%   +0.44%     
==========================================
  Files         165      166       +1     
  Lines       32475    32959     +484     
==========================================
+ Hits        22626    23109     +483     
- Misses       9849     9850       +1     
Flag Coverage Δ
rust 70.11% <94.59%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify Bot closed this Aug 7, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/8fd49cb9d0 branch August 7, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants