feat: add CORS support for HTTP API and metrics endpoints #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
reviewed
Jan 5, 2026
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Hi, thanks for getting into this!
Left some comments
Comment on lines
+67
to
+69
| let origin = allow_origin | ||
| .map(|o| AllowOrigin::exact(o.parse().expect("validated in config"))) | ||
| .unwrap_or(AllowOrigin::any()); |
Member
There was a problem hiding this comment.
see comment above, this seems un-required, we should be able to receive allow_origin as AllowOrigin to not parsed it again here
Comment on lines
+274
to
+281
| if let Some(allow_origin) = &cli_args.metrics_allow_origin { | ||
| // Pre-validate the config value to give feedback to the user on node startup. | ||
| hyper::header::HeaderValue::from_str(allow_origin) | ||
| .map_err(|_| "Invalid metrics-allow-origin value")?; | ||
|
|
||
| config.http_metrics.allow_origin = Some(allow_origin.to_string()); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
we should be able to parse cli_args.allow_origin and cli_args.metrics.allow_origin as tower_http::cors::AllowOrigin to store both as AllowOrigin in the config and not have the need to parse them again later
Comment on lines
+43
to
+46
| let origin = config | ||
| .allow_origin | ||
| .map(|o| AllowOrigin::exact(o.parse().expect("validated in config"))) | ||
| .unwrap_or(AllowOrigin::any()); |
Member
There was a problem hiding this comment.
see comment above, this seems unrequired, we can have config.allow_origin's type to be AllowOrigin to not have to be parsed again here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #249
Proposed Changes
--metrics-allow-originCLI flag--http-allow-originflag existed but wasn't wired up.Additional Info
None