fix: Do not use fixed start time for proposals #762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let timer = metrics::start_timer_vec(&metrics::CONSENSUS_TIMES, &[metrics::BLOCK]); | ||
| let start_time = self.get_instant_in_slot(slot, Duration::ZERO)?; | ||
| // proposals do not use a fixed start time: https://github.com/sigp/anchor/issues/758 | ||
| let start_time = Instant::now(); |
Member
There was a problem hiding this comment.
Is this equivalent to "a relative timeout from QBFT start"?
Member
Author
There was a problem hiding this comment.
Thanks, I realized now that the Go-SSV code appears to actually also use timeouts relative to round changes, e.g. induced by justified proposals: https://github.com/ssvlabs/ssv/blob/8808f67d0660821aa3991017272655fbecfbfa04/protocol/v2/qbft/instance/proposal.go#L35-L38
I believe we therefore need two timer modes - the existing one and one to mirror the behaviour above.
Therefore this fix is not sufficient. Closing it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Instead of using the slot start as start time (which is later used for determining timeouts), use the current time.