Restore keyless attest build against cosign 3.1#828
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
cosign 3.1 unexported signcommon.GetSignerVerifier, which the attest command used to build the keyless signer, so gitsign no longer builds (sigstore#826). Rebuild the same thing inline: generate an ephemeral key, get a Fulcio cert via the still-exported fulcio.NewSigner, and wrap them in a signcommon.SignerVerifier (also still exported) so the attestor keeps working unchanged. Bumps cosign to v3.1.1. Fixes sigstore#826 Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cosign 3.1 made
signcommon.GetSignerVerifierprivate (part of the sign-via-sigstore-go rework in sigstore/cosign#4618), so the attest command stopped building - that is the #826 / Debian breakage @jas4711 hit.The struct it returned (
signcommon.SignerVerifier) andfulcio.NewSignerare both still exported, so I rebuilt whatGetSignerVerifierdid for the keyless case right inattest.go: generate an ephemeral key, get a Fulcio cert for it, and wrap both in aSignerVerifier. The attestor and its tests are untouched. Bumps cosign to v3.1.1.go build ./...(aftergo mod tidy) is clean and theinternal/attesttests pass. I couldn't exercise the real keyless Fulcio+Rekor path locally since it needs an interactive OIDC login, but the construction mirrors what cosign's ownGetSignerVerifierdid.This is the minimal change to get the build green again. If you'd rather move the attestor onto cosign's new
GetKeypairAndToken/ sigstore-go keypair flow instead (the more future-proof route that came up in the issue), I'm happy to do that as a follow-up.Fixes #826