feat(mill): add has_adjustable_speed and has_timer capability flags - #3
Merged
Conversation
silasg
force-pushed
the
feature/mill-capability-flags
branch
from
April 3, 2026 12:02
c3d4e63 to
7722b2b
Compare
Add two boolean properties to the Mill model that control whether mill_speed and mill_timer fields are visible in brew forms and detail views. When a selected grinder lacks a capability, the corresponding brew field is hidden regardless of global/preparation settings. - Extend Mill interface and class with has_adjustable_speed, has_timer (default true for backward compatibility, no migration needed) - Add HAS_ADJUSTABLE_SPEED, HAS_TIMER to millFunctionPipe - Wire choosenMill into brew-brewing and brew-detail components - Add checkboxes to mill add/edit/detail views - Add i18n keys for all supported languages - Add unit tests for Mill model and brew-brewing visibility - Fix pre-existing bug: millFunctionPipe used PREPARATION enum for HAS_PHOTOS - Increase mill-add modal breakpoint from 0.35 to 0.5 Note: Non-English translations (ar, el, es, fr, id, it, nl, no, pl, pt, tr, zh) are automated and need review by native speakers.
silasg
force-pushed
the
feature/mill-capability-flags
branch
from
April 3, 2026 12:43
7722b2b to
3fb8060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two boolean properties to the Mill model that control whether mill_speed and mill_timer fields are visible in brew forms and detail views. When a selected grinder lacks a capability, the corresponding brew field is hidden regardless of global/preparation settings.
Note: Non-English translations (ar, el, es, fr, id, it, nl, no, pl, pt, tr, zh) are automated and need review by native speakers.