Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request includes several updates to the CI configuration, dependency management, and codebase improvements. The most important changes involve simplifying the CI workflow, removing unnecessary badges, and updating code to use modern Rust conventions.
Improvements to CI workflow:
.github/workflows/ci.yml: Updated the CI workflow to use the latest versions of actions and simplified the steps by replacing specific action uses with direct commands. Removed the grcov coverage steps. [1] [2] [3]Dependency and badge updates:
Cargo.toml: Removed thebadgessection related to Coveralls.README.md: Removed the Coveralls coverage badge.Codebase improvements:
src/codec.rs: Updated various instances of deprecated type references (e.g.,std::u16::MAXtou16::MAX). [1] [2] [3] [4]src/lib.rs: Updated lifetimes in method signatures and removed unnecessary lifetimes in trait implementations. [1] [2]